Skip to content

[chatgpt] fix ppo training hanging problem with gemini#3162

Merged
ver217 merged 2 commits intohpcaitech:mainfrom
ver217:hotfix/chatgpt-gemini
Mar 17, 2023
Merged

[chatgpt] fix ppo training hanging problem with gemini#3162
ver217 merged 2 commits intohpcaitech:mainfrom
ver217:hotfix/chatgpt-gemini

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Mar 17, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Closes #3161

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. Update examples/train_prompts.py to ensure each process has the same generation steps.
  2. Update generation early stopping condition by considering DDP scheme.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added bug Something isn't working chatgpt ChatGPT Application labels Mar 17, 2023
@ver217 ver217 merged commit c474fda into hpcaitech:main Mar 17, 2023
@ver217 ver217 deleted the hotfix/chatgpt-gemini branch March 17, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chatgpt ChatGPT Application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: chatgpt ppo training hangs when using gemini

2 participants