[zero] Refactor ZeroContextConfig class using dataclass#3186
Merged
binmakeswell merged 1 commit intohpcaitech:mainfrom Mar 21, 2023
Merged
[zero] Refactor ZeroContextConfig class using dataclass#3186binmakeswell merged 1 commit intohpcaitech:mainfrom
binmakeswell merged 1 commit intohpcaitech:mainfrom
Conversation
1SAA
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
📝 What does this PR do?
This PR refactors the
ZeroContextConfigclass to use thedataclassdecorator from Python's standard library. This change simplifies the code, improves readability, and reduces the possibility of bugs due to human error.Motivation:
The
dataclassdecorator provides a more concise way to define classes with simple attributes, such as the configuration class.It automatically generates common special methods, such as
__init__,__repr__, and__eq__, reducing the need for boilerplate code.Using dataclass also makes the code more Pythonic and easier to maintain.
Changes:
Refactor
ZeroContextConfigclass to usedataclassdecoratorUpdate constructor arguments and their documentation
Add
__post_init__method for additional assertionsPlease review and let me know if any changes are required. Thanks!
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.