[Lint] Run lint by pre-commit#3239
Conversation
|
Hi @nijkah , this PR has conflict with the main branch, can you try to resolve the conflict first? |
@FrankLeeeee I fixed some conflicts between yapf and isort! |
|
@FrankLeeeee Hi. The errors on the checks don't seem to be due to this PR. This PR is just formatting. |
Hi @nijkah , I suspect that the code formatting broke something. Sometimes, the import order can matter, e.g. in C++ and CUDA files. I would like to suggest to format in a module-by-module way. This can bring two benefits.
|
|
If you like, I can handle this together with you. @nijkah |
|
@FrankLeeeee I agree with you. I'll create new PRs based on modules. |
This PR should be merged after #3238
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
fixes #3237
📝 What does this PR do?
Run lint by pre-commit.
ColossalAI/.github/workflows/post_commit.yml
Lines 66 to 67 in 280fcdc
Since the current workflow only checks changed files, it does not edit old lines.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.