Skip to content

[NFC] polish colossalai/fx/passes/split_module.py code style #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binmakeswell merged 1 commit into from
Mar 27, 2023
Merged

[NFC] polish colossalai/fx/passes/split_module.py code style #3263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions colossalai/fx/passes/split_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import inspect
from typing import Any, Callable, Dict, List, Optional

import torch
from torch.fx.graph_module import GraphModule
from typing import Callable, List, Dict, Any, Optional
from torch.fx._compatibility import compatibility
from packaging import version
import inspect
from torch.fx._compatibility import compatibility
from torch.fx.graph_module import GraphModule


@compatibility(is_backward_compatible=True)
Expand Down Expand Up @@ -38,7 +39,7 @@ def split_module(
m: GraphModule,
root_m: torch.nn.Module,
split_callback: Callable[[torch.fx.node.Node], int],
merge_output = False,
merge_output=False,
):
"""
Adapted from https://github.com/pytorch/pytorch/blob/master/torch/fx/passes/split_module.py
Expand Down Expand Up @@ -132,10 +133,8 @@ def record_cross_partition_use(def_node: torch.fx.node.Node,
use_partition.inputs.setdefault(def_node.name)
if def_partition_name is not None:
use_partition.partitions_dependent_on.setdefault(def_partition_name)

def record_output(
def_node: torch.fx.node.Node, use_node: Optional[torch.fx.node.Node]
): # noqa: B950

def record_output(def_node: torch.fx.node.Node, use_node: Optional[torch.fx.node.Node]): # noqa: B950
def_partition_name = getattr(def_node, "_fx_partition", None)
use_partition_name = getattr(use_node, "_fx_partition", None)
if def_partition_name != use_partition_name:
Expand Down Expand Up @@ -291,7 +290,7 @@ def record_output(

for partition_name in sorted_partitions:
partition = partitions[partition_name]

new_gm = torch.fx.graph_module.GraphModule(base_mod_attrs, base_mod_graph)

return new_gm