Fix/docker action#3266
Merged
FrankLeeeee merged 2 commits intohpcaitech:mainfrom May 22, 2023
Merged
Conversation
Contributor
|
Hi @liuzeming-yuxi , let me double check on this. Your code change might not work as the version branch is only created when the release post is published in https://github.com/hpcaitech/ColossalAI/releases. The workflow is like this:
It is important to note that 2 & 3 happen at the same time when 1 is completed. Therefore, I think it is not viable to do I will look into the docker image issue and get back to you. Appreciate that you found the bug, that's awesome! 🚀 |
FrankLeeeee
approved these changes
May 22, 2023
FrankLeeeee
pushed a commit
that referenced
this pull request
May 24, 2023
* [docker] Add ARG VERSION to determine the Tag * [workflow] fixed the version in the release docker workflow --------- Co-authored-by: liuzeming <liuzeming@4paradigm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
I have created an issue for this PR for traceability
The title follows the standard format:
[doc/gemini/tensor/...]: A concise descriptionI have added relevant tags if possible for us to better distinguish different PRs
🚨 Issue number
📝 What does this PR do?
Add an ARG VERSION in the Dockerfile to determine tag for Colossalai.
Bind the value version to ARG VERSION in workflows/release_docker_after_merge.yml
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.