Skip to content

[NFC] polish colossalai/engine/gradient_accumulation/_gradient_accumu… #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binmakeswell merged 1 commit into from
Mar 28, 2023
Merged

[NFC] polish colossalai/engine/gradient_accumulation/_gradient_accumu… #3277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions colossalai/engine/gradient_accumulation/_gradient_accumulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
#!/usr/bin/env python
# -*- encoding: utf-8 -*-

from typing import Union
from typing import Any, Iterable, Tuple, Union

import torch.nn as nn
from torch import Tensor
from typing import Iterable, Any, Tuple
from colossalai.nn.optimizer import ColossalaiOptimizer
from torch.nn.parallel.distributed import DistributedDataParallel
from torch.optim import Optimizer
from torch.optim.lr_scheduler import _LRScheduler
from torch.utils.data import DataLoader
from colossalai.utils import conditional_context

from colossalai.engine import BaseGradientHandler
from colossalai.nn.optimizer import ColossalaiOptimizer
from colossalai.utils import conditional_context


class GradAccumOptimizer(ColossalaiOptimizer):
"""A wrapper for the optimizer to enable gradient accumulation by skipping the steps
"""A wrapper for the optimizer to enable gradient accumulation by skipping the steps
before accumulation size is reached.

Args:
Expand Down Expand Up @@ -161,7 +162,7 @@ def __next__(self) -> Union[Tensor, Tuple[Tensor]]:


class GradAccumLrSchedulerByStep(_LRScheduler):
"""A wrapper for the LR scheduler to enable gradient accumulation by skipping the steps
"""A wrapper for the LR scheduler to enable gradient accumulation by skipping the steps
before accumulation size is reached.

Args:
Expand Down