Skip to content

[coati] fix inference profanity check#3299

Merged
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
ver217:coati/inference-fix
Mar 28, 2023
Merged

[coati] fix inference profanity check#3299
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
ver217:coati/inference-fix

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Mar 28, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

If we simply use regexp to match bad words, we may find "hello" matches "hell", which is not expected.

Thus, we must tokenize sentences before matching. We use "jiebe" to tokenize.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee merged commit 62f7156 into hpcaitech:main Mar 28, 2023
@FrankLeeeee FrankLeeeee deleted the coati/inference-fix branch March 28, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants