[chat]Move the function "save_model" into PPOTrainer#3377
Merged
ht-zhou merged 1 commit intohpcaitech:mainfrom Apr 6, 2023
Merged
[chat]Move the function "save_model" into PPOTrainer#3377ht-zhou merged 1 commit intohpcaitech:mainfrom
ht-zhou merged 1 commit intohpcaitech:mainfrom
Conversation
The function save_model should be a part of PPOTrainer. save_model函数被错误地外置到模型外部,导致rlhf train阶段无法保存模型。
Contributor
|
Thanks for your nice work. The bug occurred because some code changes occurred after our training, in order to adapt to the pipeline of huggingface. |
ht-zhou
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function save_model should be a part of PPOTrainer.
save_model函数被错误地外置到模型外部,导致rlhf train阶段无法保存模型。
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
📝 What does this PR do?
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.