Skip to content

[chat]Move the function "save_model" into PPOTrainer#3377

Merged
ht-zhou merged 1 commit intohpcaitech:mainfrom
Dr-Corgi:patch-1
Apr 6, 2023
Merged

[chat]Move the function "save_model" into PPOTrainer#3377
ht-zhou merged 1 commit intohpcaitech:mainfrom
Dr-Corgi:patch-1

Conversation

@Dr-Corgi
Copy link
Copy Markdown
Contributor

The function save_model should be a part of PPOTrainer.

save_model函数被错误地外置到模型外部,导致rlhf train阶段无法保存模型。

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

The function save_model should be a part of PPOTrainer.

save_model函数被错误地外置到模型外部,导致rlhf train阶段无法保存模型。
@ht-zhou ht-zhou changed the title Move the function "save_model" into PPOTrainer [chat]Move the function "save_model" into PPOTrainer Apr 6, 2023
@ht-zhou
Copy link
Copy Markdown
Contributor

ht-zhou commented Apr 6, 2023

Thanks for your nice work. The bug occurred because some code changes occurred after our training, in order to adapt to the pipeline of huggingface.

@ht-zhou ht-zhou self-assigned this Apr 6, 2023
@ht-zhou ht-zhou merged commit 73afb63 into hpcaitech:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants