Skip to content

[doc] polish diffusion example#3386

Merged
binmakeswell merged 4 commits intohpcaitech:mainfrom
janroudaut:patch-2
Apr 1, 2023
Merged

[doc] polish diffusion example#3386
binmakeswell merged 4 commits intohpcaitech:mainfrom
janroudaut:patch-2

Conversation

@janroudaut
Copy link
Copy Markdown
Contributor

@janroudaut janroudaut commented Mar 31, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

📝 What does this PR do?

  • Changes to the "Step 3" (XFormers) section: rewording, fixed badly formatted URL ;
  • Misc (minor) typo, grammar and formatting fixes based on a diagonal reading.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks goos all typo correction was corrected

@binmakeswell binmakeswell changed the title [examples/images/diffusion]: README.md: more typo fixes [doc] polish diffusion example Apr 1, 2023
@binmakeswell binmakeswell merged commit dd367ce into hpcaitech:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants