Skip to content

[test] fixed gemini plugin test#3411

Merged
FrankLeeeee merged 3 commits intohpcaitech:mainfrom
FrankLeeeee:hotfix/ci
Apr 3, 2023
Merged

[test] fixed gemini plugin test#3411
FrankLeeeee merged 3 commits intohpcaitech:mainfrom
FrankLeeeee:hotfix/ci

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

@FrankLeeeee FrankLeeeee commented Apr 3, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3413

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the memory leakage in the auto parallel module and unskipped the gemini plugin test.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee changed the title [tesxed gemini plugin test [test] fixed gemini plugin test Apr 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2023

The code coverage for the changed files is 46%.

Click me to view the complete report
Name                                                      Stmts   Miss  Cover
-----------------------------------------------------------------------------
colossalai/auto_parallel/offload/base_offload_module.py      71     47    34%
colossalai/auto_parallel/offload/mem_optimize.py             36     24    33%
colossalai/auto_parallel/offload/runtime.py                 146    126    14%
colossalai/auto_parallel/offload/util.py                     58     30    48%
tests/test_auto_parallel/test_offload/test_perf.py          112     85    24%
tests/test_booster/test_plugin/test_gemini_plugin.py         72      5    93%
tests/test_zero/low_level_zero/test_zero1_2.py               93      1    99%
-----------------------------------------------------------------------------
TOTAL                                                       588    318    46%

@FrankLeeeee FrankLeeeee merged commit 638a07a into hpcaitech:main Apr 3, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/ci branch April 3, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Memory Leak due to CUDA Stream

2 participants