Skip to content

[booster] fixed the torch ddp plugin with the new checkpoint api#3442

Merged
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
FrankLeeeee:hotfix/torch-ddp-plugin-example
Apr 6, 2023
Merged

[booster] fixed the torch ddp plugin with the new checkpoint api#3442
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
FrankLeeeee:hotfix/torch-ddp-plugin-example

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3441

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR refactored the booster plugins with the new checkpointIO APIs. Tested for both TorchDDP and Gemini plugins.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2023

The code coverage for the changed files is 84%.

Click me to view the complete report
Name                                            Stmts   Miss  Cover
-------------------------------------------------------------------
colossalai/booster/plugin/gemini_plugin.py        117     16    86%
colossalai/booster/plugin/torch_ddp_plugin.py      73     15    79%
-------------------------------------------------------------------
TOTAL                                             190     31    84%

@FrankLeeeee FrankLeeeee merged commit 7d8d825 into hpcaitech:main Apr 6, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/torch-ddp-plugin-example branch April 6, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Adapt the booster plugins with the refactored chekcpointIO API

2 participants