Skip to content

[checkpoint] Shard saved checkpoint need to be compatible with the naming format of hf checkpoint files #3479

Merged
FrankLeeeee merged 7 commits intohpcaitech:mainfrom
flybird11111:main
Apr 12, 2023
Merged

[checkpoint] Shard saved checkpoint need to be compatible with the naming format of hf checkpoint files #3479
FrankLeeeee merged 7 commits intohpcaitech:mainfrom
flybird11111:main

Conversation

@flybird11111
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • [ yes ] I have created an issue for this PR for traceability
  • [ yes ] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • [ yes ] I have added relevant tags if possible for us to better distinguish different PRs

🚨 fixed #3463

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

fix shard saved checkpoint files to be compatible with hf file naming format

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • [ yes ] I have linked my PR to an issue (instruction)
  • [ yes ] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • [ yes ] I have performed a self-review of my code
  • [ yes ] I have added thorough tests.
  • [ yes ] I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@flybird11111 flybird11111 changed the title [checkpoint] support huggingface style sharded checkpoint, to be compatible with hf file naming format [checkpoint] support huggingface style sharded checkpoint, to be compatible with the naming format of hf checkpoint file Apr 6, 2023
@flybird11111 flybird11111 changed the title [checkpoint] support huggingface style sharded checkpoint, to be compatible with the naming format of hf checkpoint file [checkpoint] support huggingface style sharded checkpoint, to be compatible with the naming format of hf checkpoint files Apr 6, 2023
@flybird11111 flybird11111 changed the title [checkpoint] support huggingface style sharded checkpoint, to be compatible with the naming format of hf checkpoint files [checkpoint] Shard saved checkpoint to be compatible with the naming format of hf checkpoint files Apr 6, 2023
@flybird11111 flybird11111 changed the title [checkpoint] Shard saved checkpoint to be compatible with the naming format of hf checkpoint files [checkpoint] Shard saved checkpoint need to be compatible with the naming format of hf checkpoint files Apr 6, 2023
@FrankLeeeee
Copy link
Copy Markdown
Contributor

LGTM.

Comment thread colossalai/checkpoint_io/utils.py
@FrankLeeeee FrankLeeeee merged commit 366a035 into hpcaitech:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[checkpoint] support huggingface style sharded checkpoint

2 participants