Skip to content

Update docker push to have latest#3561

Closed
elfarouk wants to merge 2 commits intohpcaitech:mainfrom
elfarouk:patch-1
Closed

Update docker push to have latest#3561
elfarouk wants to merge 2 commits intohpcaitech:mainfrom
elfarouk:patch-1

Conversation

@elfarouk
Copy link
Copy Markdown

This is to avoid having the error when pulling with cmd (docker pull hpcaitech/colossalai)

📌 Checklist before creating the PR

  • [ x] I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

#3560

📝 What does this PR do?

Modify .github/workflows/release_docker_after_merge.yml to add "latest" tag creation

💥 Checklist before requesting a review

  • [x ] I have linked my PR to an issue (instruction)
  • [ x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • [ x] I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

This is to avoid having the error when pulling with cmd (docker pull hpcaitech/colossalai)
@elfarouk
Copy link
Copy Markdown
Author

Dear maintainer, can you have a look to this proposal.

This is a first draft, not sure 100% compatible with all the requirments

Thanks in advance

@FrankLeeeee
Copy link
Copy Markdown
Contributor

Hi @elfarouk , I think this PR is good, just could you resolve the conflict? Appreciate it!

@FrankLeeeee
Copy link
Copy Markdown
Contributor

Replaced by #3920 as this PR is not active. Thanks for @elfarouk for the contribution. Will close this issue now.

@FrankLeeeee FrankLeeeee closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants