Skip to content

[fx] fix meta tensor registration#3589

Merged
FrankLeeeee merged 4 commits intohpcaitech:mainfrom
ver217:hotfix/meta-tensor
Apr 18, 2023
Merged

[fx] fix meta tensor registration#3589
FrankLeeeee merged 4 commits intohpcaitech:mainfrom
ver217:hotfix/meta-tensor

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Apr 18, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Meta registration for meta tensor is not compatible with torch>1.12.1. This PR fixes compatibility.

I tested on torch 1.12.0-2.0.0:

image

image

image

image

image

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee merged commit dac127d into hpcaitech:main Apr 18, 2023
@ver217 ver217 deleted the hotfix/meta-tensor branch April 18, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants