Skip to content

Fixed several spelling errors under colossalai#3618

Merged
binmakeswell merged 17 commits intohpcaitech:mainfrom
digger-yu:main
Apr 26, 2023
Merged

Fixed several spelling errors under colossalai#3618
binmakeswell merged 17 commits intohpcaitech:mainfrom
digger-yu:main

Conversation

@digger-yu
Copy link
Copy Markdown
Contributor

@digger-yu digger-yu commented Apr 21, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Not involved

📝 What does this PR do?

Optimization Code
Fixed several spelling errors under colossalai,The code logic is not modified
Note on readme.md file changes
GitHub's image caching mechanism will cache images,Add a random number after the last modified link.
so that every time you visit that link, the contributor's image will be refreshed in real time.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@binmakeswell
Copy link
Copy Markdown
Member

Hi @digger-yu Thanks for the contribution. Could you please fix above comments? Thanks.

@binmakeswell binmakeswell self-requested a review April 21, 2023 09:54
@digger-yu
Copy link
Copy Markdown
Contributor Author

sorry,I don't understand too well, what I need to do ?

@binmakeswell
Copy link
Copy Markdown
Member

sorry,I don't understand too well, what I need to do ?

Hi @digger-yu Don't worry. You can update these changes according to above comments at digger-yu:main, then we will review it. Thanks.

@binmakeswell
Copy link
Copy Markdown
Member

binmakeswell commented Apr 24, 2023

Hi @digger-yu Thank you for your careful contribution. I have reviewed all the content and think it is pretty nice!
I would suggest you fix the bugs according to the above comments first at your branch, and then I can merge this PR.
Because Colossal-AI is in high-speed development, modifying too many files at one time is likely to cause conflicts with other contributors' PRs, causing unnecessary extra work.
For example, you can split your further PR according to the path, docs/example/colossalai/application/etc.
Thanks.

@digger-yu
Copy link
Copy Markdown
Contributor Author

digger-yu commented Apr 24, 2023

@binmakeswell
It's an honor to contribute to the open source world.
I'll go through it all as soon as I can, it's almost done.
Most of the changes are actually words in comments.
The individual changes like Usgae::Usage:: are related to the code logic.
But I think this is just to restore the function of its design.

all done.please check

@binmakeswell
Copy link
Copy Markdown
Member

image

Hi @digger-yu
Could you please fix bugs according to comments at the beginning of this PR first, rather than adding new changes? It may only take a few minutes. You've modified almost a hundred files at once, which is a lot for a PR.
Although these changes aren't related to the code logic, unfortunately, some of them are incorrect, and we should fix them before merging this PR.
Thank you very much.

revert autograft to autograd
@digger-yu
Copy link
Copy Markdown
Contributor Author

digger-yu commented Apr 25, 2023

@binmakeswell
Sorry for the trouble you caused
question 1 :it just add a random number to make sure that each visit is the latest list of images and not cached, it is effective
question 2 :Already revert

Comment thread README.md Outdated
Comment thread colossalai/auto_parallel/passes/runtime_preparation_pass.py
Comment thread colossalai/autochunk/reorder_graph.py Outdated
Comment thread colossalai/autochunk/search_chunk.py Outdated
Comment thread colossalai/cli/check/check_installation.py Outdated
Comment thread docs/source/en/features/1D_tensor_parallel.md Outdated
Comment thread docs/source/en/features/2D_tensor_parallel.md
Comment thread docs/source/en/features/2p5D_tensor_parallel.md
Comment thread docs/source/en/features/3D_tensor_parallel.md
Comment thread examples/language/gpt/experiments/auto_parallel/README.md Outdated
utile to until
change misteach to mismatch in line 91
revert to perceptron
revert to perceptron in line 73
revert to perceptron in line 71
revert to perceptron in line 80
revert to resnet in line 42
revert to indice in line 7
revert to megatron in line 94
revert to torchrun in line 198
change to detailed in line 63
change to detailed in line 146
revert  random number in line 402
@binmakeswell
Copy link
Copy Markdown
Member

@binmakeswell Sorry for the trouble you caused question 1 :it just add a random number to make sure that each visit is the latest list of images and not cached, it is effective question 2 :Already revert

oh, I'm so sorry, I forgot to submit the review comments and you actually cannot read them before.
Thank you very much for your patience and contribution.

@binmakeswell binmakeswell merged commit b9a8dff into hpcaitech:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants