Skip to content

Del: Remove duplicate functions#3625

Merged
binmakeswell merged 1 commit intohpcaitech:mainfrom
ddobokki:fix/ppo
Apr 24, 2023
Merged

Del: Remove duplicate functions#3625
binmakeswell merged 1 commit intohpcaitech:mainfrom
ddobokki:fix/ppo

Conversation

@ddobokki
Copy link
Copy Markdown
Contributor

@ddobokki ddobokki commented Apr 22, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge
proposal#3624

📝 What does this PR do?

Remove duplicate functions that exist within ppo.py

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@binmakeswell
Copy link
Copy Markdown
Member

Hi @ddobokki Thanks so much for your contribution!

@binmakeswell binmakeswell merged commit df309fc into hpcaitech:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants