Skip to content

[gemini] accelerate inference#3641

Merged
ver217 merged 11 commits intohpcaitech:mainfrom
ver217:feature/gemini-inference
Apr 26, 2023
Merged

[gemini] accelerate inference#3641
ver217 merged 11 commits intohpcaitech:mainfrom
ver217:feature/gemini-inference

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Apr 26, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. Accelerate gemini inference by supporting keeping fp16 params gathered in inference mode.
  2. Fix chat generation problem. Previous code has compatibility issue and kv cache may not be used.
  3. Fix chat opt benchmark.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added Run Build and Test gemini related to the gemini feature chatgpt ChatGPT Application labels Apr 26, 2023
@ver217 ver217 requested review from 1SAA and FrankLeeeee April 26, 2023 03:19
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 87%.

Click me to view the complete report
Name                                          Stmts   Miss  Cover
-----------------------------------------------------------------
colossalai/zero/gemini/gemini_ddp.py            382     66    83%
tests/components_to_test/__init__.py              4      0   100%
tests/components_to_test/utils/__init__.py        2      0   100%
tests/components_to_test/utils/executor.py       15      1    93%
tests/test_zero/test_gemini/test_fwd_bwd.py     116      1    99%
-----------------------------------------------------------------
TOTAL                                           519     68    87%

@ver217 ver217 merged commit 50793b3 into hpcaitech:main Apr 26, 2023
@ver217 ver217 deleted the feature/gemini-inference branch April 26, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chatgpt ChatGPT Application gemini related to the gemini feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants