Skip to content

[booster] refactor all dp fashion plugins#3684

Merged
ver217 merged 4 commits intohpcaitech:mainfrom
ver217:refactor/plugin
May 5, 2023
Merged

[booster] refactor all dp fashion plugins#3684
ver217 merged 4 commits intohpcaitech:mainfrom
ver217:refactor/plugin

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented May 4, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Closes #3683

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. Write a base class (DPPluginBase) for all dp fashion plugins. It contains dataloader creation and dist attributes setup logic.
  2. Update corresponding unit test.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added Run Build and Test API related to API changes labels May 4, 2023
@ver217 ver217 requested a review from FrankLeeeee May 4, 2023 10:49
@ver217 ver217 self-assigned this May 4, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2023

The code coverage for the changed files is 87%.

Click me to view the complete report
Name                                                           Stmts   Miss  Cover
----------------------------------------------------------------------------------
colossalai/booster/plugin/dp_plugin_base.py                       22      4    82%
colossalai/booster/plugin/gemini_plugin.py                        75     12    84%
colossalai/booster/plugin/low_level_zero_plugin.py                77      6    92%
colossalai/booster/plugin/torch_ddp_plugin.py                     57     11    81%
tests/test_booster/test_plugin/test_dp_plugin_base.py             47      8    83%
tests/test_booster/test_plugin/test_gemini_plugin.py              74     10    86%
tests/test_booster/test_plugin/test_low_level_zero_plugin.py      60      6    90%
tests/test_booster/test_plugin/test_torch_ddp_plugin.py           40      0   100%
----------------------------------------------------------------------------------
TOTAL                                                            452     57    87%

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2023

The code coverage for the changed files is 87%.

Click me to view the complete report
Name                                                           Stmts   Miss  Cover
----------------------------------------------------------------------------------
colossalai/booster/plugin/dp_plugin_base.py                       22      4    82%
colossalai/booster/plugin/gemini_plugin.py                        75     12    84%
colossalai/booster/plugin/low_level_zero_plugin.py                77      6    92%
colossalai/booster/plugin/torch_ddp_plugin.py                     57     11    81%
tests/test_booster/test_plugin/test_dp_plugin_base.py             47      8    83%
tests/test_booster/test_plugin/test_gemini_plugin.py              74     10    86%
tests/test_booster/test_plugin/test_low_level_zero_plugin.py      60      6    90%
tests/test_booster/test_plugin/test_torch_ddp_plugin.py           40      0   100%
----------------------------------------------------------------------------------
TOTAL                                                            452     57    87%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2023

The code coverage for the changed files is 88%.

Click me to view the complete report
Name                                                           Stmts   Miss  Cover
----------------------------------------------------------------------------------
colossalai/booster/plugin/dp_plugin_base.py                       22      4    82%
colossalai/booster/plugin/gemini_plugin.py                        98     12    88%
colossalai/booster/plugin/low_level_zero_plugin.py                77      6    92%
colossalai/booster/plugin/torch_ddp_plugin.py                     57     11    81%
tests/test_booster/test_plugin/test_dp_plugin_base.py             47      8    83%
tests/test_booster/test_plugin/test_gemini_plugin.py              74     10    86%
tests/test_booster/test_plugin/test_low_level_zero_plugin.py      60      6    90%
tests/test_booster/test_plugin/test_torch_ddp_plugin.py           40      0   100%
----------------------------------------------------------------------------------
TOTAL                                                            475     57    88%

@ver217 ver217 merged commit d0915f5 into hpcaitech:main May 5, 2023
@ver217 ver217 deleted the refactor/plugin branch May 5, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API related to API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[booster] refactor all dp plugins

2 participants