Skip to content

[booster] support torch fsdp plugin in booster#3697

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
wukong1992:feature/fsdpplugin
May 15, 2023
Merged

[booster] support torch fsdp plugin in booster#3697
ver217 merged 1 commit intohpcaitech:mainfrom
wukong1992:feature/fsdpplugin

Conversation

@wukong1992
Copy link
Copy Markdown
Contributor

@wukong1992 wukong1992 commented May 6, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Booster support torch FSDP plugin.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py
Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py Outdated
@wukong1992 wukong1992 changed the title feature: support torch fsdp plugin in booster [Booster] feature: support torch fsdp plugin in booster May 8, 2023
@wukong1992 wukong1992 requested a review from ver217 May 8, 2023 05:57
Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py Outdated
Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py Outdated
Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py Outdated
@ver217 ver217 changed the title [Booster] feature: support torch fsdp plugin in booster [booster] support torch fsdp plugin in booster May 8, 2023
@ver217 ver217 added the API related to API changes label May 8, 2023
@wukong1992 wukong1992 requested a review from ver217 May 10, 2023 03:25
Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py Outdated
@wukong1992 wukong1992 requested a review from ver217 May 12, 2023 08:31
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 42%.

Click me to view the complete report
Name                                                       Stmts   Miss  Cover
------------------------------------------------------------------------------
colossalai/booster/plugin/__init__.py                         10      2    80%
colossalai/booster/plugin/torch_fsdp_plugin.py               111    111     0%
colossalai/testing/utils.py                                   86      7    92%
tests/test_booster/test_plugin/test_torch_fsdp_plugin.py      46     27    41%
------------------------------------------------------------------------------
TOTAL                                                        253    147    42%

@ver217
Copy link
Copy Markdown
Contributor

ver217 commented May 15, 2023

The code coverage for the changed files is 42%.

Click me to view the complete report

Torch version of CI is 1.11.0. Test is skipped.

@ver217 ver217 merged commit b37797e into hpcaitech:main May 15, 2023
@wukong1992 wukong1992 deleted the feature/fsdpplugin branch May 15, 2023 08:40
FrankLeeeee pushed a commit that referenced this pull request May 24, 2023
Co-authored-by: 纪少敏 <jishaomin@jishaomindeMBP.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API related to API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants