Skip to content

[booster] fix no_sync method#3709

Merged
FrankLeeeee merged 7 commits intohpcaitech:mainfrom
ver217:hotfix/no_sync
May 9, 2023
Merged

[booster] fix no_sync method#3709
FrankLeeeee merged 7 commits intohpcaitech:mainfrom
ver217:hotfix/no_sync

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented May 8, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Closes #3708

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. Add no_sync() method in Plugin class.
  2. Implement this method in subclasses.
  3. Add test for torch DDP no_sync

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added bug Something isn't working Run Build and Test API related to API changes labels May 8, 2023
@ver217 ver217 self-assigned this May 8, 2023
@ver217 ver217 requested a review from FrankLeeeee May 8, 2023 07:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2023

The code coverage for the changed files is 88%.

Click me to view the complete report
Name                                                      Stmts   Miss  Cover
-----------------------------------------------------------------------------
colossalai/booster/plugin/gemini_plugin.py                  100     13    87%
colossalai/booster/plugin/low_level_zero_plugin.py           79      7    91%
colossalai/booster/plugin/plugin_base.py                     40     10    75%
colossalai/booster/plugin/torch_ddp_plugin.py                60     11    82%
tests/test_booster/test_plugin/test_dp_plugin_base.py        49      9    82%
tests/test_booster/test_plugin/test_torch_ddp_plugin.py      78      0   100%
-----------------------------------------------------------------------------
TOTAL                                                       406     50    88%

@FrankLeeeee FrankLeeeee merged commit 6552cbf into hpcaitech:main May 9, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/no_sync branch May 9, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API related to API changes bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[booster] fix no_sync method

2 participants