Skip to content

[booster] removed models that fsdp not support in test#3744

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
wukong1992:hotfix/fsdpplugin
May 15, 2023
Merged

[booster] removed models that fsdp not support in test#3744
ver217 merged 1 commit intohpcaitech:mainfrom
wukong1992:hotfix/fsdpplugin

Conversation

@wukong1992
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

removed modes that fsdp not support in test.

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 self-requested a review May 15, 2023 10:30
@ver217 ver217 added Run Build and Test API related to API changes labels May 15, 2023
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is %.

Click me to view the complete report
Name                                                       Stmts   Miss  Cover
------------------------------------------------------------------------------
tests/test_booster/test_plugin/test_torch_fsdp_plugin.py      46      0   100%
------------------------------------------------------------------------------
TOTAL                                                         46      0   100%

@ver217 ver217 merged commit 6050f37 into hpcaitech:main May 15, 2023
FrankLeeeee pushed a commit that referenced this pull request May 24, 2023
Co-authored-by: 纪少敏 <jishaomin@jishaomindeMBP.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API related to API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants