Skip to content

[devops] fix ci for document check#3751

Merged
FrankLeeeee merged 14 commits intohpcaitech:mainfrom
ver217:hoftix/doc-ci
May 17, 2023
Merged

[devops] fix ci for document check#3751
FrankLeeeee merged 14 commits intohpcaitech:mainfrom
ver217:hoftix/doc-ci

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented May 16, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Closes #3753

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

As described in #3753 , the merge behavior is unexpected, in this PR:

  1. Fix branch merge behavior.
  2. Update comments.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Comment thread .github/workflows/doc_check_on_pr.yml
@ver217 ver217 changed the title [WIP][devops] test documentation check ci [devops] fix ci for document check May 17, 2023
@ver217 ver217 added bug Something isn't working DevOps labels May 17, 2023
@FrankLeeeee FrankLeeeee merged commit 5dd573c into hpcaitech:main May 17, 2023
@FrankLeeeee FrankLeeeee deleted the hoftix/doc-ci branch May 17, 2023 03:24
FrankLeeeee pushed a commit that referenced this pull request May 24, 2023
* [doc] add test info

* [devops] update doc check ci

* [devops] add debug info

* [devops] add debug info

* [devops] add debug info

* [devops] add debug info

* [devops] add debug info

* [devops] add debug info

* [devops] add debug info

* [devops] add debug info

* [devops] add debug info

* [devops] add debug info

* [devops] remove debug info and update invalid doc

* [devops] add essential comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working DevOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[devops] fix ci for document check

2 participants