Skip to content

[chat] fix bugs in stage 3 training#3759

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
chengeharrison:fix/chat
May 17, 2023
Merged

[chat] fix bugs in stage 3 training#3759
ver217 merged 1 commit intohpcaitech:mainfrom
chengeharrison:fix/chat

Conversation

@chengeharrison
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

fixed #3746 fixed #3658

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. Fix the code in ppo.py which always read same data from prompt_dataloader
  2. Fix the example which wrongly converts a seed dataset into a prompt dataset.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@chengeharrison chengeharrison added the chatgpt ChatGPT Application label May 17, 2023
Comment thread applications/Chat/examples/generate_prompt_dataset.py Outdated
Comment thread applications/Chat/examples/generate_prompt_dataset.py Outdated
Comment thread applications/Chat/examples/generate_prompt_dataset.py Outdated
Comment thread applications/Chat/examples/generate_prompt_dataset.sh Outdated
@ver217 ver217 merged commit 0575983 into hpcaitech:main May 17, 2023
FrankLeeeee pushed a commit that referenced this pull request May 24, 2023
Co-authored-by: Yuanchen Xu <yuanchen.xu00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chatgpt ChatGPT Application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: code in ppo.py always read same datas from prompt_dataloader [BUG]: prompt jsonl file read ERROR

2 participants