Skip to content

[plugin] a workaround for zero plugins' optimizer checkpoint#3780

Merged
FrankLeeeee merged 4 commits intohpcaitech:mainfrom
ver217:hotfix/optim-ckpt
May 19, 2023
Merged

[plugin] a workaround for zero plugins' optimizer checkpoint#3780
FrankLeeeee merged 4 commits intohpcaitech:mainfrom
ver217:hotfix/optim-ckpt

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented May 19, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Closes #3776

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. Update low level zero and gemini plugin. Saves optimizer checkpoint on each process with different name.
  2. Add warning info.
  3. Update unit test.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added the API related to API changes label May 19, 2023
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 96%.

Click me to view the complete report
Name                                                            Stmts   Miss  Cover
-----------------------------------------------------------------------------------
colossalai/booster/plugin/gemini_plugin.py                        106      9    92%
colossalai/booster/plugin/low_level_zero_plugin.py                 85      6    93%
tests/test_checkpoint_io/test_gemini_checkpoint_io.py              80      0   100%
tests/test_checkpoint_io/test_low_level_zero_checkpoint_io.py      46      0   100%
tests/test_checkpoint_io/test_torch_ddp_checkpoint_io.py           56      0   100%
tests/test_checkpoint_io/utils.py                                  14      0   100%
-----------------------------------------------------------------------------------
TOTAL                                                             387     15    96%

@FrankLeeeee FrankLeeeee merged commit 3c07a28 into hpcaitech:main May 19, 2023
@ver217 ver217 deleted the hotfix/optim-ckpt branch May 22, 2023 02:56
FrankLeeeee pushed a commit that referenced this pull request May 24, 2023
* [test] refactor torch ddp checkpoint test

* [plugin] update low level zero optim checkpoint

* [plugin] update gemini optim checkpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API related to API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[plugin] a workaround for zero plugins' optimizer checkpoint

3 participants