[evaluate] add functions for gpt evaluation#3781
Merged
chengeharrison merged 1 commit intohpcaitech:dev/evaluationfrom May 22, 2023
Merged
[evaluate] add functions for gpt evaluation#3781chengeharrison merged 1 commit intohpcaitech:dev/evaluationfrom
chengeharrison merged 1 commit intohpcaitech:dev/evaluationfrom
Conversation
chengeharrison
force-pushed
the
dev/evaluate
branch
from
5b94d54 to
d8cf444
Compare
TongLi3701
reviewed
May 20, 2023
Contributor
TongLi3701
left a comment
TongLi3701
left a comment
There was a problem hiding this comment.
Thanks Yuanchen.
Overall looks good. Some minor comments .
chengeharrison
force-pushed
the
dev/evaluate
branch
from
d8cf444 to
32910de
Compare
TongLi3701
approved these changes
May 22, 2023
Contributor
TongLi3701
left a comment
TongLi3701
left a comment
There was a problem hiding this comment.
Thanks YuanChen.
Overall looks great. Just one minor comment.
Please merge once everyone is approved.
| import pandas as pd | ||
| import seaborn as sns | ||
| import tqdm | ||
| from utils import jdump, jload |
Contributor
There was a problem hiding this comment.
It seems that utils is internal package?
If so, it should be the third group according the guideline: https://composed.blog/python/imports
Contributor
Author
There was a problem hiding this comment.
Ok, I will fix that.
ver217
reviewed
May 22, 2023
chengeharrison
force-pushed
the
dev/evaluate
branch
from
32910de to
2b6e8e1
Compare
ver217
approved these changes
May 22, 2023
Camille7777
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
#3714
📝 What does this PR do?
Add functions to enable gpt evaluation.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.