Skip to content

[booster] torch fsdp fix ckpt#3788

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
wukong1992:feature/fsdpckpt
May 23, 2023
Merged

[booster] torch fsdp fix ckpt#3788
ver217 merged 1 commit intohpcaitech:mainfrom
wukong1992:feature/fsdpckpt

Conversation

@wukong1992
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py Outdated
@wukong1992 wukong1992 marked this pull request as ready for review May 23, 2023 07:26
@wukong1992 wukong1992 requested a review from ver217 May 23, 2023 07:26
Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py Outdated
Comment thread tests/test_checkpoint_io/test_torch_fsdp_checkpoint_io.py Outdated
Comment thread tests/test_checkpoint_io/test_torch_fsdp_checkpoint_io.py Outdated
Comment thread tests/test_checkpoint_io/test_torch_fsdp_checkpoint_io.py Outdated
@wukong1992 wukong1992 requested a review from ver217 May 23, 2023 08:31
@ver217 ver217 added the API related to API changes label May 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is %.

Click me to view the complete report
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
colossalai/booster/booster.py                                  63     10    84%
colossalai/booster/plugin/torch_fsdp_plugin.py                 93     12    87%
colossalai/checkpoint_io/general_checkpoint_io.py              69      7    90%
tests/test_booster/test_plugin/test_torch_fsdp_plugin.py       43      0   100%
tests/test_checkpoint_io/test_torch_fsdp_checkpoint_io.py      83      6    93%
-------------------------------------------------------------------------------
TOTAL                                                         351     35    90%

@ver217 ver217 merged commit 6b305a9 into hpcaitech:main May 23, 2023
@wukong1992 wukong1992 deleted the feature/fsdpckpt branch May 23, 2023 09:04
FrankLeeeee pushed a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API related to API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants