Skip to content

[shardformer] refactored the user api#3828

Merged
FoolPlayer merged 2 commits intohpcaitech:feature/shardformerfrom
FrankLeeeee:hotfix/shardformer-api
May 24, 2023
Merged

[shardformer] refactored the user api#3828
FoolPlayer merged 2 commits intohpcaitech:feature/shardformerfrom
FrankLeeeee:hotfix/shardformer-api

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

N/A

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR refactored the shardformer to expose a simple function to the user. It is more common to expose this feature as a function instead of a class. Meanwhile, some unused imports and functions are removed as well.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee requested a review from FoolPlayer May 24, 2023 05:56
@FrankLeeeee FrankLeeeee added enhancement New feature or request shardformer labels May 24, 2023
@FoolPlayer FoolPlayer merged commit d2dd4dd into hpcaitech:feature/shardformer May 24, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/shardformer-api branch May 24, 2023 08:02
FrankLeeeee added a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 8, 2023
* [shardformer] refactored the user api

* polish code
FrankLeeeee added a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 8, 2023
* [shardformer] refactored the user api

* polish code
FrankLeeeee added a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 8, 2023
* [shardformer] refactored the user api

* polish code
FrankLeeeee added a commit that referenced this pull request Jun 26, 2023
* [shardformer] refactored the user api

* polish code
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Jul 3, 2023
* [shardformer] refactored the user api

* polish code
FrankLeeeee added a commit that referenced this pull request Jul 4, 2023
* [shardformer] refactored the user api

* polish code
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
* [shardformer] refactored the user api

* polish code
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
* [shardformer] refactored the user api

* polish code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request shardformer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants