Skip to content

[doc] add warning for torch fsdp plugin doc#3833

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
wukong1992:feature/fsdpwarn
May 25, 2023
Merged

[doc] add warning for torch fsdp plugin doc#3833
ver217 merged 1 commit intohpcaitech:mainfrom
wukong1992:feature/fsdpwarn

Conversation

@wukong1992
Copy link
Copy Markdown
Contributor

@wukong1992 wukong1992 commented May 24, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

add warning for torch fsdp plugin doc: now fsdp not support optimizer that use multi params group
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 changed the title [booster] add warning for torch fsdp plugin doc [doc] add warning for torch fsdp plugin doc May 24, 2023
@ver217 ver217 added the documentation Improvements or additions to documentation label May 24, 2023
@wukong1992 wukong1992 requested a review from ver217 May 24, 2023 09:23
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 86%.

Click me to view the complete report
Name                                             Stmts   Miss  Cover
--------------------------------------------------------------------
colossalai/booster/plugin/torch_fsdp_plugin.py      96     13    86%
--------------------------------------------------------------------
TOTAL                                               96     13    86%

@ver217 ver217 merged commit 3229f93 into hpcaitech:main May 25, 2023
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants