Skip to content

[dtensor] polish sharding spec docstring#3838

Merged
ver217 merged 2 commits intohpcaitech:feature/dtensorfrom
ver217:doc/dtensor
May 25, 2023
Merged

[dtensor] polish sharding spec docstring#3838
ver217 merged 2 commits intohpcaitech:feature/dtensorfrom
ver217:doc/dtensor

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented May 25, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added the documentation Improvements or additions to documentation label May 25, 2023
@ver217 ver217 requested a review from FrankLeeeee May 25, 2023 03:30
@ver217 ver217 self-assigned this May 25, 2023
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 87%.

Click me to view the complete report
Name                                          Stmts   Miss  Cover
-----------------------------------------------------------------
colossalai/tensor/d_tensor/sharding_spec.py     105     14    87%
-----------------------------------------------------------------
TOTAL                                           105     14    87%

@ver217 ver217 merged commit 7c9f2ed into hpcaitech:feature/dtensor May 25, 2023
@ver217 ver217 deleted the doc/dtensor branch May 25, 2023 05:09
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
* [dtensor] polish sharding spec docstring

* [dtensor] polish sharding spec example docstring
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
* [dtensor] polish sharding spec docstring

* [dtensor] polish sharding spec example docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants