Skip to content

[workflow] fixed workflow check for docker build#3849

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
FrankLeeeee:hotfix/docker-release
May 25, 2023
Merged

[workflow] fixed workflow check for docker build#3849
ver217 merged 1 commit intohpcaitech:mainfrom
FrankLeeeee:hotfix/docker-release

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3848

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the docker build workflow so that it will not get skipped upon release.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee added bug Something isn't working DevOps labels May 25, 2023
@ver217 ver217 merged commit ae959a7 into hpcaitech:main May 25, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/docker-release branch May 25, 2023 08:47
FrankLeeeee added a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working DevOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: docker build workflow is skipped upon release

2 participants