Skip to content

[bf16] cpu adam and hybrid adam optimizers support bf16#3860

Merged
FrankLeeeee merged 8 commits intohpcaitech:feature/bf16from
ver217:feature/cpu-adam-bf16
May 30, 2023
Merged

[bf16] cpu adam and hybrid adam optimizers support bf16#3860
FrankLeeeee merged 8 commits intohpcaitech:feature/bf16from
ver217:feature/cpu-adam-bf16

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented May 29, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

#3839

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. CPU adam and hybrid adam support native bf16.
  2. Refactor adam kernel and optimizer tests.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added the enhancement New feature or request label May 29, 2023
@ver217 ver217 requested a review from FrankLeeeee May 29, 2023 08:33
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 95%.

Click me to view the complete report
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
colossalai/nn/optimizer/cpu_adam.py           68      3    96%
colossalai/nn/optimizer/fused_adam.py         55     10    82%
colossalai/nn/optimizer/hybrid_adam.py        63      3    95%
tests/test_optimizer/test_adam_kernel.py      87      1    99%
tests/test_optimizer/test_adam_optim.py       49      0   100%
--------------------------------------------------------------
TOTAL                                        322     17    95%

@FrankLeeeee FrankLeeeee merged commit 2e799c7 into hpcaitech:feature/bf16 May 30, 2023
@ver217 ver217 deleted the feature/cpu-adam-bf16 branch May 30, 2023 02:40
FrankLeeeee pushed a commit that referenced this pull request Jun 5, 2023
* [bf16] add bf16 support for fused adam (#3844)

* [bf16] fused adam kernel support bf16

* [test] update fused adam kernel test

* [test] update fused adam test

* [bf16] cpu adam and hybrid adam optimizers support bf16 (#3860)

* [bf16] implement mixed precision mixin and add bf16 support for low level zero (#3869)

* [bf16] add mixed precision mixin

* [bf16] low level zero optim support bf16

* [text] update low level zero test

* [text] fix low level zero grad acc test

* [bf16] add bf16 support for gemini (#3872)

* [bf16] gemini support bf16

* [test] update gemini bf16 test

* [doc] update gemini docstring

* [bf16] add bf16 support for plugins (#3877)

* [bf16] add bf16 support for legacy zero (#3879)

* [zero] init context support bf16

* [zero] legacy zero support bf16

* [test] add zero bf16 test

* [doc] add bf16 related docstring for legacy zero
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
* [bf16] add bf16 support for fused adam (hpcaitech#3844)

* [bf16] fused adam kernel support bf16

* [test] update fused adam kernel test

* [test] update fused adam test

* [bf16] cpu adam and hybrid adam optimizers support bf16 (hpcaitech#3860)

* [bf16] implement mixed precision mixin and add bf16 support for low level zero (hpcaitech#3869)

* [bf16] add mixed precision mixin

* [bf16] low level zero optim support bf16

* [text] update low level zero test

* [text] fix low level zero grad acc test

* [bf16] add bf16 support for gemini (hpcaitech#3872)

* [bf16] gemini support bf16

* [test] update gemini bf16 test

* [doc] update gemini docstring

* [bf16] add bf16 support for plugins (hpcaitech#3877)

* [bf16] add bf16 support for legacy zero (hpcaitech#3879)

* [zero] init context support bf16

* [zero] legacy zero support bf16

* [test] add zero bf16 test

* [doc] add bf16 related docstring for legacy zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants