Skip to content

[evaluation] improvement on evaluation#3862

Merged
chengeharrison merged 5 commits intohpcaitech:mainfrom
chengeharrison:feature/evaluation
May 30, 2023
Merged

[evaluation] improvement on evaluation#3862
chengeharrison merged 5 commits intohpcaitech:mainfrom
chengeharrison:feature/evaluation

Conversation

@chengeharrison
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. fix a bug when the config file contains one category but the answer file doesn't contains that category
  2. fix Chinese prompt file
  3. support gpt-3.5-turbo and gpt-4 evaluation
  4. polish and update README

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yuanchen.

Overall looks good. Some minor comments.
Please also test locally make sure everything is runnable including GPT eval and Automatic eval.

Please make all table headers centre such as Description, Chinese Example and so on.

Comment thread applications/Chat/evaluate/evaluator.py Outdated
Comment thread applications/Chat/evaluate/README.md Outdated
Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yuanchen.

@chengeharrison chengeharrison merged commit 2506e27 into hpcaitech:main May 30, 2023
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
* fix a bug when the config file contains one category but the answer file doesn't contains that category

* fix Chinese prompt file

* support gpt-3.5-turbo and gpt-4 evaluation

* polish and update README

* resolve pr comments

---------

Co-authored-by: Yuanchen Xu <yuanchen.xu00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants