Skip to content

[nfc] fix typo colossalai/nn #3887

Merged
FrankLeeeee merged 17 commits intohpcaitech:mainfrom
digger-yu:patch1
Jun 5, 2023
Merged

[nfc] fix typo colossalai/nn #3887
FrankLeeeee merged 17 commits intohpcaitech:mainfrom
digger-yu:patch1

Conversation

@digger-yu
Copy link
Copy Markdown
Contributor

@digger-yu digger-yu commented Jun 2, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Not involved

📝 What does this PR do?

[nfc] fix typo colossalai/nn
detail info
modified: colossalai/nn/layer/parallel_sequence/layers.py
modified: colossalai/nn/loss/loss_1d.py
modified: colossalai/nn/loss/loss_2d.py
modified: colossalai/nn/loss/loss_2p5d.py
modified: colossalai/nn/loss/loss_3d.py
modified: colossalai/nn/optimizer/cpu_adam.py
modified: colossalai/nn/optimizer/lamb.py
modified: colossalai/nn/optimizer/nvme_optimizer.py
modified: colossalai/nn/parallel/layers/cache_embedding/cached_embedding.py
modified: colossalai/nn/parallel/layers/cache_embedding/copyer.py
modified: colossalai/nn/parallel/layers/cache_embedding/parallel_cached_embedding_tablewise_split_cache.py

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Comment thread colossalai/nn/parallel/layers/cache_embedding/cached_embedding.py
Copy link
Copy Markdown
Contributor

@FrankLeeeee FrankLeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FrankLeeeee FrankLeeeee merged commit 1878749 into hpcaitech:main Jun 5, 2023
@digger-yu digger-yu deleted the patch1 branch June 5, 2023 08:26
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
* fix typo colossalai/autochunk auto_parallel amp

* fix typo colossalai/auto_parallel nn utils etc.

* fix typo colossalai/auto_parallel autochunk fx/passes  etc.

* fix typo docs/

* change placememt_policy to placement_policy in docs/ and examples/

* fix typo colossalai/ applications/

* fix typo colossalai/cli fx kernel

* fix typo colossalai/nn

* revert change warmuped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants