Skip to content

[doc] Fix a bug about booster api in the documentation.#3898

Merged
ver217 merged 2 commits intohpcaitech:mainfrom
Fridge003:fix_booster_doc
Jun 6, 2023
Merged

[doc] Fix a bug about booster api in the documentation.#3898
ver217 merged 2 commits intohpcaitech:mainfrom
Fridge003:fix_booster_doc

Conversation

@Fridge003
Copy link
Copy Markdown
Contributor

@Fridge003 Fridge003 commented Jun 5, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

fixed #3897

📝 What does this PR do?

Fixed this bug by replacing Adam with HybridAdam in the documentation.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@Fridge003 Fridge003 changed the title [DOC]: Fix a bug about booster api in the documentation. [doc]: Fix a bug about booster api in the documentation. Jun 5, 2023
@ver217 ver217 added the documentation Improvements or additions to documentation label Jun 5, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2023

The code coverage for the changed files is 84%.

Click me to view the complete report
Name                            Stmts   Miss  Cover
---------------------------------------------------
colossalai/booster/booster.py      63     10    84%
---------------------------------------------------
TOTAL                              63     10    84%

@ver217 ver217 changed the title [doc]: Fix a bug about booster api in the documentation. [doc] Fix a bug about booster api in the documentation. Jun 6, 2023
@ver217 ver217 merged commit c1535cc into hpcaitech:main Jun 6, 2023
@Fridge003 Fridge003 deleted the fix_booster_doc branch June 6, 2023 06:14
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC]: A bug about usage of booster api in the document

2 participants