Skip to content

[lazy] fix compatibility problem on torch 1.13#3911

Merged
ver217 merged 2 commits intohpcaitech:mainfrom
ver217:hotfix/lazy
Jun 7, 2023
Merged

[lazy] fix compatibility problem on torch 1.13#3911
ver217 merged 2 commits intohpcaitech:mainfrom
ver217:hotfix/lazy

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Jun 6, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

On torch 1.13, lazy init context has compatibility problem and the unit tests will fail. This PR fix this problem.

I run unit tests on local machine with torch==1.13.1:
image

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added the bug Something isn't working label Jun 6, 2023
@ver217 ver217 requested a review from FrankLeeeee June 6, 2023 09:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2023

The code coverage for the changed files is 87%.

Click me to view the complete report
Name                           Stmts   Miss  Cover
--------------------------------------------------
colossalai/lazy/lazy_init.py     298     40    87%
--------------------------------------------------
TOTAL                            298     40    87%

@ver217 ver217 merged commit 9c88b6c into hpcaitech:main Jun 7, 2023
@ver217 ver217 deleted the hotfix/lazy branch June 7, 2023 03:10
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants