Skip to content

[nfc] fix typo applications/Chat/coati/#3947

Merged
flybird11111 merged 1 commit intohpcaitech:mainfrom
digger-yu:patch1
Jun 15, 2023
Merged

[nfc] fix typo applications/Chat/coati/#3947
flybird11111 merged 1 commit intohpcaitech:mainfrom
digger-yu:patch1

Conversation

@digger-yu
Copy link
Copy Markdown
Contributor

@digger-yu digger-yu commented Jun 9, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Not involved

📝 What does this PR do?

fix typo applications/Chat/coati/
modified: applications/Chat/coati/ray/experience_maker_holder.py
modified: applications/Chat/coati/ray/lora_constructor.py
modified: applications/Chat/coati/trainer/strategies/colossalai.py
Make code easier to read

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@digger-yu digger-yu changed the title fix typo applications/Chat/coati/ [nfc] fix typo applications/Chat/coati/ Jun 9, 2023
@TongLi3701 TongLi3701 requested a review from binmakeswell June 13, 2023 02:10
@flybird11111 flybird11111 merged commit d4fb7bf into hpcaitech:main Jun 15, 2023
@digger-yu digger-yu deleted the patch1 branch June 15, 2023 02:44
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants