[doc] add a note about unit-testing to CONTRIBUTING.md#3970
Merged
ver217 merged 1 commit intohpcaitech:mainfrom Jun 14, 2023
Merged
[doc] add a note about unit-testing to CONTRIBUTING.md#3970ver217 merged 1 commit intohpcaitech:mainfrom
ver217 merged 1 commit intohpcaitech:mainfrom
Conversation
ver217
reviewed
Jun 14, 2023
7bc15f4 to
79375a4
Compare
79375a4 to
27354db
Compare
ver217
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
fixed #3875
📝 What does this PR do?
As is discussed in the referred issue, if the version of python is too high (>=3.10) during establishing environment for unit testing, fbgemm-gpu==0.2.0 cannot be correctly downloaded.
So I'm adding a note in CONTRIBUTING.md to warn about this potential bug, so contributors can avoid wasting time on this requirement bug.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.