Skip to content

[workflow] fixed the directory check in build#3980

Merged
FrankLeeeee merged 1 commit intohpcaitech:developfrom
FrankLeeeee:hotfix/build-workflow
Jun 13, 2023
Merged

[workflow] fixed the directory check in build#3980
FrankLeeeee merged 1 commit intohpcaitech:developfrom
FrankLeeeee:hotfix/build-workflow

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

@FrankLeeeee FrankLeeeee commented Jun 13, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3981 .

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the bash if then code to avoid exit code 1 if the condition is false.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee force-pushed the hotfix/build-workflow branch from 11541f2 to f08cdd5 Compare June 13, 2023 06:26
@FrankLeeeee FrankLeeeee added bug Something isn't working DevOps labels Jun 13, 2023
@FrankLeeeee FrankLeeeee linked an issue Jun 13, 2023 that may be closed by this pull request
@FrankLeeeee FrankLeeeee merged commit 8bcad73 into hpcaitech:develop Jun 13, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/build-workflow branch June 13, 2023 06:42
Fridge003 pushed a commit to Fridge003/ColossalAI that referenced this pull request Jun 14, 2023
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working DevOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Build Failed if No CUDA Extension Cache Exists

2 participants