Skip to content

[nfc] fix dim not defined and fix typo#3991

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
digger-yu:patch1
Jun 19, 2023
Merged

[nfc] fix dim not defined and fix typo#3991
ver217 merged 1 commit intohpcaitech:mainfrom
digger-yu:patch1

Conversation

@digger-yu
Copy link
Copy Markdown
Contributor

@digger-yu digger-yu commented Jun 15, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Not involved

📝 What does this PR do?

  1. fix dim not defined
  2. fix typo
    Make code easier to read
    modified: applications/Chat/evaluate/gpt_evaluate.py
    modified: applications/Chat/evaluate/unieval/evaluator.py
    modified: applications/Chat/evaluate/unieval/utils.py
    modified: applications/Chat/tests/test_data.py

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 merged commit 727c459 into hpcaitech:main Jun 19, 2023
@digger-yu digger-yu deleted the patch1 branch June 19, 2023 03:36
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants