[shardformer] Refactor shardformer api#4001
Merged
FrankLeeeee merged 7 commits intohpcaitech:refactor/shardformerfrom Jun 15, 2023
Merged
[shardformer] Refactor shardformer api#4001FrankLeeeee merged 7 commits intohpcaitech:refactor/shardformerfrom
FrankLeeeee merged 7 commits intohpcaitech:refactor/shardformerfrom
Conversation
FrankLeeeee
reviewed
Jun 15, 2023
Comment on lines
112
to
113
| staticmethod1, | ||
| staticmethod2, |
Contributor
There was a problem hiding this comment.
The element in the param_replacement list is not staticmethod, it is just function.
FrankLeeeee
reviewed
Jun 15, 2023
FrankLeeeee
reviewed
Jun 15, 2023
| @staticmethod | ||
| def inject_policy() -> Union[Tuple[nn.Module, nn.Module], None]: | ||
| @abstractmethod | ||
| def new_model_class(self) -> Union[nn.Module, None]: |
Contributor
There was a problem hiding this comment.
-> Union[Type[nn.Module], None].
FrankLeeeee
reviewed
Jun 15, 2023
Comment on lines
+57
to
+59
| def new_model_class(self): | ||
| # do nothing | ||
| return self.model |
FrankLeeeee
approved these changes
Jun 15, 2023
FrankLeeeee
pushed a commit
to FrankLeeeee/ColossalAI
that referenced
this pull request
Jun 16, 2023
* fix an error in readme * simplify code * refactor shardformer * add todo * remove slicer * resolve code review
FrankLeeeee
pushed a commit
that referenced
this pull request
Jun 16, 2023
* fix an error in readme * simplify code * refactor shardformer * add todo * remove slicer * resolve code review
FrankLeeeee
pushed a commit
to FrankLeeeee/ColossalAI
that referenced
this pull request
Jun 21, 2023
* fix an error in readme * simplify code * refactor shardformer * add todo * remove slicer * resolve code review
FrankLeeeee
pushed a commit
that referenced
this pull request
Jun 26, 2023
* fix an error in readme * simplify code * refactor shardformer * add todo * remove slicer * resolve code review
flybird11111
pushed a commit
to flybird11111/ColossalAI
that referenced
this pull request
Jul 3, 2023
* fix an error in readme * simplify code * refactor shardformer * add todo * remove slicer * resolve code review
FrankLeeeee
pushed a commit
that referenced
this pull request
Jul 4, 2023
* fix an error in readme * simplify code * refactor shardformer * add todo * remove slicer * resolve code review
ver217
pushed a commit
to ver217/ColossalAI
that referenced
this pull request
Jul 13, 2023
* fix an error in readme * simplify code * refactor shardformer * add todo * remove slicer * resolve code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
fixed #4000
📝 What does this PR do?
Refactor shardformer api to integrate with d_tensor, etc
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.