Skip to content

[shardformer] refactored embedding and dropout to parallel module#4013

Merged
FoolPlayer merged 2 commits intohpcaitech:refactor/shardformerfrom
FrankLeeeee:hotfix/embedding-layer
Jun 16, 2023
Merged

[shardformer] refactored embedding and dropout to parallel module#4013
FoolPlayer merged 2 commits intohpcaitech:refactor/shardformerfrom
FrankLeeeee:hotfix/embedding-layer

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #4012

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR refactored the embedding and dropout layer to align with the parallel module in shardformer.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee added enhancement New feature or request shardformer labels Jun 16, 2023
@FrankLeeeee
Copy link
Copy Markdown
Contributor Author

Test screeshot:

Screenshot 2023-06-16 at 13 59 57

@FoolPlayer FoolPlayer merged commit c2bdf1f into hpcaitech:refactor/shardformer Jun 16, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/embedding-layer branch June 16, 2023 07:00
FrankLeeeee added a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 16, 2023
…caitech#4013)

* [shardformer] refactored embedding and dropout to parallel module

* polish code
FrankLeeeee added a commit that referenced this pull request Jun 16, 2023
)

* [shardformer] refactored embedding and dropout to parallel module

* polish code
FrankLeeeee added a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 21, 2023
…caitech#4013)

* [shardformer] refactored embedding and dropout to parallel module

* polish code
FrankLeeeee added a commit that referenced this pull request Jun 26, 2023
)

* [shardformer] refactored embedding and dropout to parallel module

* polish code
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Jul 3, 2023
…caitech#4013)

* [shardformer] refactored embedding and dropout to parallel module

* polish code
FrankLeeeee added a commit that referenced this pull request Jul 4, 2023
)

* [shardformer] refactored embedding and dropout to parallel module

* polish code
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
…caitech#4013)

* [shardformer] refactored embedding and dropout to parallel module

* polish code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request shardformer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants