Skip to content

[shardformer] fix bert and gpt downstream with new api#4024

Merged
FrankLeeeee merged 2 commits intohpcaitech:feature/shardformerfrom
FoolPlayer:hotfix/bert-gpt-downstream
Jun 19, 2023
Merged

[shardformer] fix bert and gpt downstream with new api#4024
FrankLeeeee merged 2 commits intohpcaitech:feature/shardformerfrom
FoolPlayer:hotfix/bert-gpt-downstream

Conversation

@FoolPlayer
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

fix bert and gpt downstream with new api

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FoolPlayer FoolPlayer added testing related to our testing shardformer labels Jun 16, 2023
Comment thread tests/test_shardformer/test_model/test_shard_bert.py Outdated
Copy link
Copy Markdown
Contributor

@FrankLeeeee FrankLeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you paste a screenshot of your testing results?

@FoolPlayer
Copy link
Copy Markdown
Contributor Author

image

@FrankLeeeee FrankLeeeee merged commit 197c89d into hpcaitech:feature/shardformer Jun 19, 2023
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jun 19, 2023
* fix bert downstream with new api

* remove comment line
FoolPlayer added a commit to FoolPlayer/ColossalAI that referenced this pull request Jun 21, 2023
* fix bert downstream with new api

* remove comment line
FrankLeeeee pushed a commit that referenced this pull request Jun 26, 2023
* fix bert downstream with new api

* remove comment line
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Jul 3, 2023
* fix bert downstream with new api

* remove comment line
FrankLeeeee pushed a commit that referenced this pull request Jul 4, 2023
* fix bert downstream with new api

* remove comment line
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
* fix bert downstream with new api

* remove comment line
@FoolPlayer FoolPlayer deleted the hotfix/bert-gpt-downstream branch September 7, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shardformer testing related to our testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shardformer] support bert/gpt2 and downstream model with new api and dtensor

2 participants