Skip to content

[chat] refactor trainer class#4080

Merged
ver217 merged 17 commits intohpcaitech:mainfrom
cwher:main
Jun 29, 2023
Merged

[chat] refactor trainer class#4080
ver217 merged 17 commits intohpcaitech:mainfrom
cwher:main

Conversation

@cwher
Copy link
Copy Markdown
Contributor

@cwher cwher commented Jun 25, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Close #4077.

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@cwher cwher requested a review from ver217 June 27, 2023 03:37
ver217
ver217 reviewed Jun 27, 2023
View reviewed changes
Comment thread applications/Chat/coati/trainer/base.py Outdated
ver217
ver217 reviewed Jun 27, 2023
View reviewed changes
Comment thread applications/Chat/coati/trainer/ppo.py Outdated
ver217
ver217 reviewed Jun 27, 2023
View reviewed changes
Comment thread applications/Chat/coati/trainer/sft.py Outdated
@cwher cwher added the chatgpt ChatGPT Application label Jun 27, 2023
@cwher cwher requested a review from ver217 June 29, 2023 02:17
@ver217 ver217 merged commit b03d64d into hpcaitech:main Jun 29, 2023
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
@cwher @ver217
[chat] refactor trainer class (hpcaitech#4080)
e91bb4f 
* to: add SLTrainer

* refactor: refactor RMTrainer and SFTTrainer

* fix: fix init file

* feat: remove on_learn_epoch fn as not used

* fix: align with modified gemini arguments

* to: add OnPolicyTrainer

* revert: add _on_learn_epoch fn

* refactor: refactor PPOTrainer

* style: rename PPOTrainer argument

* fix: align with modified PPO arguments

* test: align with modified train_prompts arguments

* chore: modify train_prompts

* docs: align with modified arguments

* fix: remove unnecessary output

* fix: move dataloader to fit fn of SLTrainer

* fix: move dataloader to fit fn of OnPolicyTrainer

* fix: modify usage of prompt and pretrain dataloader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ver217 ver217 ver217 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chatgpt ChatGPT Application

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[chat] refactor trainer class

2 participants

@cwher @ver217