Skip to content

[nfc] fix : CheckpointIndexFile is not defined#4109

Merged
Fridge003 merged 1 commit intohpcaitech:mainfrom
digger-yu:patch1
Jul 3, 2023
Merged

[nfc] fix : CheckpointIndexFile is not defined#4109
Fridge003 merged 1 commit intohpcaitech:mainfrom
digger-yu:patch1

Conversation

@digger-yu
Copy link
Copy Markdown
Contributor

@digger-yu digger-yu commented Jun 28, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Not involved

📝 What does this PR do?

fix "CheckpointIndexFile" is not defined"
modified: colossalai/checkpoint_io/utils.py line 371

Before adjustment
image

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@digger-yu digger-yu changed the title fix CheckpointIndexFile is not defined [nfc] fix : CheckpointIndexFile is not defined Jun 28, 2023
@Fridge003 Fridge003 merged commit 7e46bc8 into hpcaitech:main Jul 3, 2023
@digger-yu digger-yu deleted the patch1 branch July 3, 2023 09:38
@digger-yu
Copy link
Copy Markdown
Contributor Author

@Fridge003 @FrankLeeeee
in #4142 Modified were deleted
In the latest version there will still be this prompt
""CheckpointIndexFile" is not defined"
am i wrong ?

@Fridge003
Copy link
Copy Markdown
Contributor

There will be a circular importing error if adding from .index_file import CheckpointIndexFile.

@digger-yu
Copy link
Copy Markdown
Contributor Author

@Fridge003 in this file is there "from colossalai.checkpoint_io import CheckpointIndexFile" is better or not

ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants