Skip to content

[nfc] fix some typo colossalai/shardformer#4160

Merged
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
digger-yu:patch5
Jul 4, 2023
Merged

[nfc] fix some typo colossalai/shardformer#4160
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
digger-yu:patch5

Conversation

@digger-yu
Copy link
Copy Markdown
Contributor

@digger-yu digger-yu commented Jul 4, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Not involved

📝 What does this PR do?

fix some typo colossalai/shardformer
detail info
modified: colossalai/shardformer/README.md
modified: colossalai/shardformer/layer/loss.py
modified: colossalai/shardformer/policies/basepolicy.py
modified: colossalai/shardformer/shard/sharder.py
Make code easier to read

please check

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@digger-yu digger-yu changed the title fix some typo colossalai/shardformer [nfc] fix some typo colossalai/shardformer Jul 4, 2023
@FrankLeeeee FrankLeeeee merged commit 2ac2404 into hpcaitech:main Jul 4, 2023
@digger-yu digger-yu deleted the patch5 branch July 4, 2023 10:57
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants