Skip to content

[cli] hotfix launch command for multi-nodes#4165

Merged
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
ver217:hotfix/launch
Jul 4, 2023
Merged

[cli] hotfix launch command for multi-nodes#4165
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
ver217:hotfix/launch

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Jul 4, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Closes #4164

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Fix launch command

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added the bug Something isn't working label Jul 4, 2023
@ver217 ver217 requested a review from FrankLeeeee July 4, 2023 09:54
@FrankLeeeee FrankLeeeee merged commit 1908caa into hpcaitech:main Jul 4, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/launch branch July 4, 2023 09:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 4, 2023

The code coverage for the changed files is %.

Click me to view the complete report
Name                             Stmts   Miss  Cover
----------------------------------------------------
colossalai/cli/launcher/run.py     137    137     0%
----------------------------------------------------
TOTAL                              137    137     0%

ver217 added a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: colossalai run is stuck during multi-nodes training

2 participants