[chat] fix bugs and add unit tests#4213
Merged
ver217 merged 57 commits intohpcaitech:mainfrom Aug 2, 2023
Merged
Conversation
7c856ec to
cfe56b9
Compare
725164f to
c788d30
Compare
Contributor
Author
|
There are still several errors. DO NOT merge until they are resolved.
|
e4dd44d to
ce6fa1b
Compare
c7857e3 to
5434707
Compare
ver217
approved these changes
Jul 21, 2023
b0ea7cd to
9c1fe30
Compare
Experience replay is typically for off policy algorithms. Use this name in PPO maybe misleading.
dbf55d5 to
73e2347
Compare
df80d63 to
bb20f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
Close #4133, #4193, #4135, #4292.
📝 What does this PR do?
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.