Skip to content

[chat] fix bugs and add unit tests#4213

Merged
ver217 merged 57 commits intohpcaitech:mainfrom
cwher:go-through-trials-and-errors
Aug 2, 2023
Merged

[chat] fix bugs and add unit tests#4213
ver217 merged 57 commits intohpcaitech:mainfrom
cwher:go-through-trials-and-errors

Conversation

@cwher
Copy link
Copy Markdown
Contributor

@cwher cwher commented Jul 11, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Close #4133, #4193, #4135, #4292.

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@cwher cwher force-pushed the go-through-trials-and-errors branch from 7c856ec to cfe56b9 Compare July 13, 2023 08:49
@cwher cwher marked this pull request as ready for review July 14, 2023 05:27
@cwher cwher force-pushed the go-through-trials-and-errors branch from 725164f to c788d30 Compare July 14, 2023 05:28
@cwher
Copy link
Copy Markdown
Contributor Author

cwher commented Jul 18, 2023

There are still several errors. DO NOT merge until they are resolved.

@cwher cwher force-pushed the go-through-trials-and-errors branch 2 times, most recently from e4dd44d to ce6fa1b Compare July 19, 2023 03:40
@cwher cwher requested a review from ver217 July 19, 2023 08:51
@cwher cwher force-pushed the go-through-trials-and-errors branch from c7857e3 to 5434707 Compare July 21, 2023 02:07
@cwher cwher force-pushed the go-through-trials-and-errors branch 3 times, most recently from b0ea7cd to 9c1fe30 Compare July 22, 2023 13:31
@cwher cwher changed the title [chat] add unit tests [chat] fix bugs and add unit tests Jul 31, 2023
@cwher cwher force-pushed the go-through-trials-and-errors branch from dbf55d5 to 73e2347 Compare August 1, 2023 09:47
@cwher cwher force-pushed the go-through-trials-and-errors branch from df80d63 to bb20f43 Compare August 1, 2023 12:26
@ver217 ver217 merged commit da4f7b8 into hpcaitech:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[chat] add unit tests

2 participants