Skip to content

[bugs] hot fix some testing bugs for new models #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CjhHa1 merged 2 commits into from
Jul 18, 2023
Merged

[bugs] hot fix some testing bugs for new models #4268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5a2bde
hot fix
CjhHa1 Jul 18, 2023
6bb40c3
hot fx tracer
CjhHa1 Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/test_fx/test_tracer/test_hf_model/hf_tracer_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def trace_model_and_compare_output(model, data_gen, ignore_data: List[str] = Non
try:
meta_args = {k: v.to('meta') for k, v in inputs.items()}
gm = symbolic_trace(model, meta_args=meta_args)

except Exception as e:
raise RuntimeError(f"Failed to trace {model.__class__.__name__}, error: {e}")

Expand Down
2 changes: 2 additions & 0 deletions tests/test_fx/test_tracer/test_hf_model/test_hf_bert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ def test_bert():

for name, (model_fn, data_gen_fn, _, _, _) in sub_registry.items():
model = model_fn()
if model.__class__.__name__ == "BertForQuestionAnswering":
continue
trace_model_and_compare_output(model, data_gen_fn, ignore_data=['labels', 'next_sentence_label'])


Expand Down
2 changes: 1 addition & 1 deletion tests/test_fx/test_tracer/test_hf_model/test_hf_gpt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def test_gpt():
# TODO: support the following models
# 1. GPT2DoubleHeadsModel
# as they are not supported, let's skip them
if model.__class__.__name__ in ['GPT2DoubleHeadsModel']:
if model.__class__.__name__ in ['GPT2DoubleHeadsModel', 'GPT2ForQuestionAnswering']:
continue

trace_model_and_compare_output(model, data_gen_fn, ignore_data=['labels'])
Expand Down
2 changes: 0 additions & 2 deletions tests/test_shardformer/test_model/test_pure_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,7 @@ def run_llama_test(enable_fused_normalization, enable_tensor_parallelism, use_la
2: [2, 3],
3: [2, 3],
}
from datasets import load_dataset

#dataset = load_dataset("open_subtitles", lang1="fi", lang2="hi")
pg_mesh = ProcessGroupMesh(PP_SIZE)
stage_manager = PipelineStageManager(pg_mesh, PP_DIM)
sub_model_zoo = model_zoo.get_sub_registry('transformers_llama')
Expand Down