[hotfix] fix localhost measurement#4320
Merged
FrankLeeeee merged 1 commit intohpcaitech:mainfrom Aug 1, 2023
Gy-Lu:main
Merged
[hotfix] fix localhost measurement#4320FrankLeeeee merged 1 commit intohpcaitech:mainfrom Gy-Lu:main
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
Gy-Lu:main
Conversation
ver217
reviewed
Jul 25, 2023
ver217
approved these changes
Jul 25, 2023
Contributor
|
The code coverage for the changed files is %. Click me to view the complete report |
Contributor
|
The code coverage for the changed files is %. Click me to view the complete report |
FrankLeeeee
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
fixed #4318
📝 What does this PR do?
The error msg in the issue shows that each node thinks it is the localhost, and here is the question.
I print the
localaddrsandhostaddrsof the second node:Under the current implementation, at the first iter, it returns True(whether it is localhost), which is not the fact.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.