Update flash_attention to version 2.0.1#4323
Closed
kkk55596 wants to merge 1 commit intohpcaitech:mainfrom
Closed
Conversation
|
wow. According to Flash Attention's webiste
It would be great if this PR can pass the review and be accepted. |
Contributor
|
@kkk55596 Thank you so much for contribution. We will actually provide the general Here are few tips for you:
|
kurisusnowdeng
suggested changes
Jul 25, 2023
| flash_attn_unpadded_func, | ||
| flash_attn_unpadded_kvpacked_func, | ||
| flash_attn_unpadded_qkvpacked_func, | ||
| flash_attn_varlen_func, |
Contributor
There was a problem hiding this comment.
As commented in conversations
Contributor
|
The code coverage for the changed files is 11%. Click me to view the complete report |
Contributor
|
Closed since the same feature has been completed by #4347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
fixed #4322
📝 What does this PR do?
According to Flash Attention, I modify
flash_attention.pyandrequirements-test.txtfor supporting flashattn v2.0.1💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.